Is this the right form to update hooks to OS4?

8 posts / 0 new

Log in or register to post comments

Last post

Mon, 2014-01-13 18:53

#1

jabirulo

jabirulo's picture

Offline

Last seen: 5 hours 8 min ago

Joined: 2013-05-30 00:53

Is this the right form to update hooks to OS4?

Hi, just updated hooktest.c to use OS4 hooks "mode". It works fine. IS this the right way if updating/coding? Or must I for every AllocSys.. add FreeSys..?

TIA

;/*
gcc hooktest2.c -o HookTest2 -Wall -lauto -gstabs
quit
*/
#include <proto/dos.h>
#include <proto/locale.h>
#include <proto/exec.h>
 
 
void fmtfunct(struct Hook *hook, struct Locale *locale, ULONG ch)
{
 char *buffer = (char *)hook->h_Data;
 *buffer++ = ch;
 hook->h_Data = (APTR)buffer;
}
 
 
int main(void)
{
 struct DateStamp ds;
 char buffer[30];
 struct Hook *prhook;
 
 IDOS->DateStamp(&ds);
 
// fmthook.h_Entry = (HOOKFUNC)fmtfunct;
// fmthook.h_Data = (APTR)buffer;
 prhook = (struct Hook *)IExec->AllocSysObjectTags(ASOT_HOOK,
                                     ASOHOOK_Entry, fmtfunct,
                                     ASOHOOK_Data, buffer, TAG_DONE);
 ILocale->FormatDate(NULL,"%d-%m-%Y", &ds, prhook);
 IDOS->Printf("Fecha: %s\n",buffer);
 
// fmthook.h_Entry = (HOOKFUNC)fmtfunct;
// fmthook.h_Data = (APTR)buffer;
 prhook = (struct Hook *)IExec->AllocSysObjectTags(ASOT_HOOK,
                                     ASOHOOK_Entry, fmtfunct,
                                     ASOHOOK_Data, buffer, TAG_DONE);
 ILocale->FormatDate(NULL,"%d", &ds, prhook);
 IDOS->Printf("Day: %s\n",buffer);
 
// fmthook.h_Entry = (HOOKFUNC)fmtfunct;
// fmthook.h_Data = (APTR)buffer;
 prhook = (struct Hook *)IExec->AllocSysObjectTags(ASOT_HOOK,
                                     ASOHOOK_Entry, fmtfunct,
                                     ASOHOOK_Data, buffer, TAG_DONE);
 ILocale->FormatDate(NULL,"%m", &ds, prhook);
 IDOS->Printf("Month: %s ",buffer);
// fmthook.h_Entry = (HOOKFUNC)fmtfunct;
// fmthook.h_Data = (APTR)buffer;
 prhook = (struct Hook *)IExec->AllocSysObjectTags(ASOT_HOOK,
                                     ASOHOOK_Entry, fmtfunct,
                                     ASOHOOK_Data, buffer, TAG_DONE);
 ILocale->FormatDate(NULL,"%B", &ds, prhook);
 IDOS->Printf("(%s)\n",buffer);
 
// fmthook.h_Entry = (HOOKFUNC)fmtfunct;
// fmthook.h_Data = (APTR)buffer;
 prhook = (struct Hook *)IExec->AllocSysObjectTags(ASOT_HOOK,
                                     ASOHOOK_Entry, fmtfunct,
                                     ASOHOOK_Data, buffer, TAG_DONE);
 ILocale->FormatDate(NULL,"%Y", &ds, prhook);
 IDOS->Printf("Year: %s\n",buffer);
 
 IExec->FreeSysObject(ASOT_HOOK, prhook);
 return(RETURN_OK);
}

Tue, 2014-01-14 17:41

#2

trixie

trixie's picture

Offline

Last seen: 1 month 9 hours ago

Joined: 2011-02-03 13:58

Or must I for every

Or must I for every AllocSys.. add FreeSys..?

Of course! Each AllocSysObject() is an allocation so it must be deallocated, regardless of your using a single variable for the hook pointer.

AmigaOne X5000-020 / 2GB RAM / Sapphire Pulse Radeon RX 560 / AmigaOS 4.1 Final Edition Update 2

Wed, 2014-01-15 11:23

(Reply to #2) #3

jabirulo

jabirulo's picture

Offline

Last seen: 5 hours 8 min ago

Joined: 2013-05-30 00:53

OK, THX.

OK, THX.

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Wed, 2014-01-15 14:28

(Reply to #3) #4

thomas

thomas's picture

Offline

Last seen: 4 days 6 hours ago

Joined: 2011-05-16 14:23

I would call AllocSysObject

I would call AllocSysObject only once in the beginning and then only poke the new buffer pointer into hook->h_Data. You do this in your fmtfunct routine anyway, so it should be legal for the main routine, too.

Thu, 2014-01-16 14:20

(Reply to #4) #5

jabirulo

jabirulo's picture

Offline

Last seen: 5 hours 8 min ago

Joined: 2013-05-30 00:53

Hi, as I'm not very good

Hi, as I'm not very good coder.
How do I "poke the new buffer pointer into hook->h_Data"?

BTW I found another way to get Year/Month/Day values:

 int32 D_today, M_today, Y_today;
 struct DateTime dt;
 char dt_str[11], buffer[11];
 // Get current date
 IDOS->DateStamp(&dt.dat_Stamp);
 dt.dat_Format  = FORMAT_ISO; // YYYY-MM-DD (dt_str "positions view" 0123-56-89)
 dt.dat_Flags   = 0;
 dt.dat_StrDay  = NULL;
 dt.dat_StrDate = dt_str;
 dt.dat_StrTime = NULL;
 IDOS->DateToStr(&dt);
 
 IUtility->Strlcpy(buffer, dt_str, 5); // copy only the YEAR
 IDOS->StrToLong(buffer, &Y_today);
 
 IUtility->Strlcpy(buffer, dt_str+5, 3); // "strange" mode to copy only the MONTH
 IDOS->StrToLong(buffer, &M_today);
 
 IUtility->Strlcpy(buffer, dt_str+8, 3); // "strange" mode to copy only the DAY
 IDOS->StrToLong(buffer, &D_today);

Is there a better/proper way to do what I'm trying to achieve (get Date and split YYYY MM DD into integer variables)?

TIA

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Thu, 2014-01-16 22:24

(Reply to #5) #6

gazelle

gazelle's picture

Offline

Last seen: 9 months 4 weeks ago

Joined: 2011-04-13 12:52

uint32 seconds;struct

uint32 seconds;
struct DateStamp ds;
struct ClockData cd;
 
IDOS->DateStamp(&ds);
seconds = IDOS->DateStampToSeconds(&ds);
IUtility->Amiga2Date(seconds, &cd);

From utility/date.h:

struct ClockData
{
    UWORD sec;   /* 0..59 */
    UWORD min;   /* 0..59 */
    UWORD hour;  /* 0..23 */
    UWORD mday;  /* 1..31 */
    UWORD month; /* 1..12 */
    UWORD year;  /* 1978.. */
    UWORD wday;  /* 0..6; 0 == Sunday */
};

Thu, 2014-01-16 23:10

(Reply to #6) #7

thomas

thomas's picture

Offline

Last seen: 4 days 6 hours ago

Joined: 2011-05-16 14:23

How do I "poke the new buffer

How do I "poke the new buffer pointer into hook->h_Data"?

hook->h_Data = (APTR)buffer;

Sat, 2014-01-18 02:35

#8

jabirulo

jabirulo's picture

Offline

Last seen: 5 hours 8 min ago

Joined: 2013-05-30 00:53

@gazelle & @thomas THX both

@gazelle & @thomas THX both modes working fine.

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Log in or register to post comments