Asl.library FileRequester crashes when selected assign/volume doesn't exist

12 posts / 0 new

Last post

Mon, 2016-09-05 11:23

blmara

Offline

Last seen: 2 years 2 months ago

Joined: 2013-10-31 00:20

Asl.library FileRequester crashes when selected assign/volume doesn't exist

Hi, in my program I use Asl file requester both through IASL->AslRequestTags and through getfile.gadget functions. I noticed that for some reason, both ways lead to crash if I give non-existing volume name to either ASLFR_InitialDrawer or entering such in the file requester Drawer field. If entering only non-existing drawer name (without volume name like Test:) causes fr to ask whether one should create a new drawer, as it should. I extracted my Asl code to the file above. This code, however, doesn't crash but ask for reassignment as it should. I'm quite puzzled what's causing this. Would the GR log help to understand the problem. BTW, I don't have any global library bases stored in my program but using only the interfaces, would this affect asl.library? I'm using AmigaOne X1000, OS41FE, the kernel.debug is effective. Extracted code (which, runned separately, doesn't crash!)

#include <proto/asl.h>
#include <proto/dos.h>
#include <proto/exec.h>
#include <libraries/asl.h>
#include "string.h"
 
/* 
** compiled with:
** vc aslproblem.c -o ram:aslproblem +newlib
*/
 
struct AslIFace *IAsl;
struct FileRequester *FileReq;
struct Library *base;
STRPTR Testname = "Test:testing";
 
int main(int ac,char *av[])
{
	STRPTR docname,dirname;
	int dirlen;
 
	if (base = IExec->OpenLibrary("asl.library",53L))
	{
		if (IAsl = (struct AslIFace *)IExec->GetInterface(base,"main",1,NULL))
		{
			FileReq = IAsl->AllocAslRequestTags(ASL_FileRequest,
    			ASLFR_StayOnTop,TRUE,
				ASLFR_RejectIcons,TRUE,
				ASLFR_PrivateIDCMP,TRUE,
				ASLFR_SleepWindow,TRUE,
				ASLFR_DoPatterns,TRUE,
				TAG_DONE);
			dirlen = IDOS->FilePart(Testname) - Testname;
			if (dirname = IExec->AllocVecTags(dirlen+1,TAG_DONE))
			{	
				strncpy(dirname,Testname,dirlen);
				*(dirname+dirlen) = '\0';	/* note: strncpy doesn't put NUL if strlen(Testname) > dirlen! */
			}
			if (FileReq)
			{
				IAsl->AslRequestTags(FileReq,
					ASLFR_TitleText,"Testing!",
					ASLFR_InitialDrawer,dirname,
					ASLFR_InitialFile,IDOS->FilePart(Testname),
					ASLFR_InitialPattern,"(#?.xml|#?.mxl)",
					ASLFR_DoSaveMode,TRUE,
					TAG_DONE);
				IAsl->FreeAslRequest(FileReq);
			}
			if (dirname)
				IExec->FreeVec(dirname);
			IExec->DropInterface((struct Interface *)IAsl);
		}
	  IExec->CloseLibrary(base);
	}
	return(0);
}

and GR log through Sashimi (here, the SaveAsDoc() is the routine calling AslRequestTags. Note that requester starts properly. Crash comes when one enters the non-existing Test: volume name into Drawer field of requester.

"DEVS:lpr.device" Hunk 0000 Offset 00000000 (SegList: 0x1658912d)
ADDR: 6ffb8700 9126bc00 00000000 00000000 00000000 00000000 00000000 57cc1150
Page information:
Page not found
 
 
[_impl_AddTask] Adding Task 0x596241b0, Background CLI (0x5a6302a0)
[_impl_AddTask] Task = 0x596241b0, ETask = 0xdfb47e50, Context = 0xdfb9e3e0
[_impl_AddTask] Stack bottom = 0x5e3e9038, Stack top = 0x5e3ed024, Stack pointer = 0x5e3ecff0
[_impl_AddTask] Task added to ready list

Marko

Mon, 2016-09-05 19:00

xenic

Offline

Last seen: 3 months 1 week ago

Joined: 2011-05-07 04:52

Re: Asl.library FileRequester crashes when selected assign...

Without the ability to reproduce the crash, I can't help but maybe someone else can. However, I can comment on an unrelated issue in your example code. I don't think you will need line 37and the accompanying comment if you replace strncpy() with strlcpy(). Here is one of many explanations you can find by googling strlcpy: https://en.wikibooks.org/wiki/C_Programming/C_Reference/nonstandard/strlcpy

X1000 - OS 4.1FE

Mon, 2016-09-05 19:13

(Reply to #2) #3

blmara

Offline

Last seen: 2 years 2 months ago

Joined: 2013-10-31 00:20

Re: Asl.library FileRequester crashes when selected assign...

@xenic Thanks, I actually found this link also while wondering why my drawer names looked so odd ;-> Marko

Marko

Wed, 2016-09-07 00:21

(Reply to #3) #4

jabirulo

Offline

Last seen: 17 hours 6 min ago

Joined: 2013-05-30 00:53

Re: Asl.library FileRequester crashes when selected assign...

and if you put hardcoded drawer and filename does it crash too?

ASLFR_InitialDrawer, "Test:",
ASLFR_InitialFile, "testing",

AOS4.1/SAM460ex/PPC460EX-1155MHZ/2048MB/RadeonHD6570/SSD120GB/DVDRW :-P

Thu, 2016-09-08 13:47

(Reply to #4) #5

salass00

Offline

Last seen: 1 week 6 days ago

Joined: 2011-02-03 11:27

Re: Asl.library FileRequester crashes when selected assign...

Given that the number of characters to copy is known it would be more efficient to just replace strncpy() with memcpy(). BTW I tried writing a phony volume name in both a file requester (both normal and save type) and in a getfile gadget but I wasn't able to make it crash like this on my AmigaOS 4.1 beta install.

Thu, 2016-09-08 15:26

hypex

Offline

Last seen: 3 weeks 1 day ago

Joined: 2011-09-09 16:20

Re: Asl.library FileRequester crashes when selected assign...

If you want to be consistent in your code you could use malloc() or calloc() if you like it cleared. You said you don't store global library bases but where do you put them? For your own use you only need the interface pointer. But the library base will need to be opened obviously and closed later. This begs the question. You extracted code that works by itself. But what do you do with the library base? Is your code single threaded? You open ASL library and interface from one task and call it from that one task? Otherwise you can get into trouble.

Sat, 2016-09-10 19:20

(Reply to #6) #7

blmara

Offline

Last seen: 2 years 2 months ago

Joined: 2013-10-31 00:20

Re: Asl.library FileRequester crashes when selected assign...

@jabirulo Yes, it crashes then too. Marko

Marko

Sat, 2016-09-10 19:29

(Reply to #7) #8

blmara

Offline

Last seen: 2 years 2 months ago

Joined: 2013-10-31 00:20

Re: Asl.library FileRequester crashes when selected assign...

@hypex Single threaded currently. I use these routines at start and end of my program to make opening/closing libraries (and Reaction classes with slightly modified code) more compact and the possible error message output esier. So, the library base needed when closing a library is captured from struct Interface.

struct Interface *InitIface(STRPTR libname,ULONG libversion,STRPTR ifacename,ULONG ifaceversion)
{
	struct Interface *iface = NULL;
	struct Library *base;
 
	/*
	** Opens a global interface of a library. Note that the library base
	** is not saved to global library base variable anymore (see SDK 53.24
	** release FAQ.  
	**
	** IExec and IDOS are opened by compiler code automatically.
	** application.library's lib base is obtained from IApplication
	** if it has been already GetInterface()'d to avoid double opening.
	** 
	** Note that if a different thread/task uses the same interface, it
	** has to do a iface->Obtain()---iface->Release() pair see autodoc
	** of IExec->GetInterface().
	*/
	if (ifacename == prefsifacename)
	  base = IApplication->Data.LibBase;
	else
	  base = IExec->OpenLibrary(libname,libversion);
 
	if (base)
	{
	  if (iface = IExec->GetInterface(base,ifacename,ifaceversion,NULL))
	  {
	  /* ok */
	  }
	  else
	  	if (ifacename != prefsifacename)	/* don't close application.library if prefsobjects interface failed */
	     IExec->CloseLibrary(base);
	}
 
	if (iface == NULL)
		ErrorCode = MSG_ERROR_LIBRARYWONTOPEN;
	return(iface);
}
 
void CloseIFace(struct Interface *iface)
{
	struct Library *base;
 
	/* 
	** Drops interface and closes a library 
	** Doesn't close library if application.library's IPrefsObject cause still in use
	*/	
	if (iface)
	{
		base = iface->Data.LibBase;
		IExec->DropInterface(iface);
		if (iface != (struct Interface *)IPrefsObjects)
		  IExec->CloseLibrary(base);
	}
}

Marko

Sun, 2016-09-11 16:18

(Reply to #8) #9

hypex

Offline

Last seen: 3 weeks 1 day ago

Joined: 2011-09-09 16:20

Re: Asl.library FileRequester crashes when selected assign...

@blmara Okay I can understand now. I've considered doing something similar myself. I thought shortcuts may be standardised but so far looks like we are still on our own. For example I had this idea to give standard Amiga libraries ID numbers so that a table could be built up with the ones you want. And possibly passing the pointer addresses as well but automating it would be good. Anyway will do some tests when I'm on OS4 next. If the base and interface pointer are correctly initialised then there should be no problem. But youy never know until you find it. :-)

Tue, 2016-09-13 19:59

(Reply to #9) #10

hypex

Offline

Last seen: 3 weeks 1 day ago

Joined: 2011-09-09 16:20

Re: Asl.library FileRequester crashes when selected assign...

Three things come to mind. Your library opening code is different for a start. That may cause an issue. It's possible dirname could be a rogue string. I've had random corruption when not all characters were cleared and I used "hacks" to poke EOL bytes in. In your bad code try clearing the whole string before copying. In your good code fil lit with "rogue" chars before your copy. Passing patterns to file requester. I've had trouble with this and it may have only been on OS4 I noticed or when it crashed. It's only mentioned for ASLFR_RejectPattern and ASLFR_AcceptPattern but according to that ParsePatternNoCase() must be used when passing a pattern. And a normal pattern string is not acceptable.

Sat, 2016-09-17 18:55

(Reply to #10) #11

blmara

Offline

Last seen: 2 years 2 months ago

Joined: 2013-10-31 00:20

Re: Asl.library FileRequester crashes when selected assign...

@hypex Thanks, I tried something: - put up a normal AslBase - cleared the dirname buffer with memset() - removed InitialPattern These didn't help, crashed if I put Test: to drawer gadget. Still wondering. Marko

Marko

Sun, 2016-09-18 02:14

(Reply to #11) #12

thomas

Offline

Last seen: 4 days 17 hours ago

Joined: 2011-05-16 14:23

Re: Asl.library FileRequester crashes when selected assign...

Well, it obviously crashes when trying to show the "please inset volume Test in any drive" requester. It runs through IPrefs, requester.class and crashes somewhere in intuition.library. So the question is, did you do something to the standard environment? Did you change the default public screen? Did you do something to your Process->pr_WindowPtr? What about ASLFR_Window and ASLFR_Screen? Do you supply these and are they valid window resp. screen pointers? In your above example you put ASLFR_SleepWindow,TRUE which does not make any sense without a ASLFR_Window. Did you actually read up all the tags you are using and did you understand what they are good for? You should make an example which uses *exactly* the code from your crashing program. I.e. keep the SaveAsDoc routine as is, just add a new main() routine as a test driver.

Search form

User login